-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMRxRecon challenge 2023 participation scripts #274
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 84.76% 84.80% +0.03%
==========================================
Files 96 96
Lines 6963 7185 +222
==========================================
+ Hits 5902 6093 +191
- Misses 1061 1092 +31 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, in general:
- Might it be possible to deduplicate or define more abstract base classes?
- Use pathlib
- Avoid randomness in the dataset classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
This PR incrorporates code used for DIRECT team participation at the CMRxRecon challenge 2023:
CMRxReconDataset
which allows for 2D or 3D data loading.Cartesian
subsampling functions (similar to :class:FastMRI
, but instead ofcenter_fractions
representing the fraction of center lines to the original size, here, it represents the actual number of center lines).yaml
,lst
files) for reproducing our experiments.Also it introduces improvements to documentation and typing for edited files.