-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds 3D vSHARP model #273
Adds 3D vSHARP model #273
Conversation
georgeyiasemis
commented
Mar 28, 2024
- Implements 3D version of vSHARP model (Original paper: https://arxiv.org/abs/2309.09954)
- Implements 3D version of U-Net (extending https://github.com/NKI-AI/direct/blob/main/direct/nn/unet/unet_2d.py)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
+ Coverage 84.05% 84.76% +0.70%
==========================================
Files 95 96 +1
Lines 6742 6963 +221
==========================================
+ Hits 5667 5902 +235
+ Misses 1075 1061 -14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks, mostly about documentation and variable choice and typing