Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new model vSHARP & CMR challenge along with 3D reconstruction code #254

Closed
wants to merge 50 commits into from

Conversation

georgeyiasemis
Copy link
Contributor

@georgeyiasemis georgeyiasemis commented Sep 20, 2023

  • vSHARP Model: Supporting both 2D and 3D. (Details: vSHARP Paper)
  • CMRxRecon Challenge Code: Includes necessary code and dataset for the CMRxRecon challenge. Learn more about the challenge here.
  • 3D Reconstruction Experiments: Various additions, such as transforms, engine changes (e.g., visualization), and the addition of new metrics and losses.
  • Cartesian Subsampling Masks: Similar to FastMRI but with a twist - selection of the number of center lines instead of center fractions for ACS.
  • Project Organization: Introduces new project folders for vSHARP and the CMRxRecon challenge.
  • Model Zoo for CMRxRecon Winning Solution
  • Minor Code Quality Enhancements

…code (dataset, cartesuan subsampling), new metrics, transformer models
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Attention: 137 lines in your changes are missing coverage. Please review.

Comparison is base (2a4c293) 83.93% compared to head (174ed7d) 84.48%.

Files Patch % Lines
direct/data/datasets.py 79.59% 30 Missing ⚠️
direct/nn/mri_models.py 80.58% 20 Missing ⚠️
direct/data/mri_transforms.py 86.60% 15 Missing ⚠️
direct/functionals/hfen.py 81.08% 14 Missing ⚠️
direct/data/h5_data.py 14.28% 12 Missing ⚠️
direct/engine.py 25.00% 12 Missing ⚠️
direct/nn/vsharp/vsharp.py 92.40% 12 Missing ⚠️
direct/common/subsample.py 91.17% 6 Missing ⚠️
direct/nn/conv/conv.py 93.65% 4 Missing ⚠️
direct/functionals/snr.py 87.50% 3 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   83.93%   84.48%   +0.55%     
==========================================
  Files          91       96       +5     
  Lines        6298     7316    +1018     
==========================================
+ Hits         5286     6181     +895     
- Misses       1012     1135     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 10, 2023
@github-actions github-actions bot added the ci label Nov 10, 2023
@georgeyiasemis
Copy link
Contributor Author

Thank you for the PR. Check my comments.

All checked! I also added readmes for the two new projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci documentation Improvements or additions to documentation python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants