Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Espirit sensitivity estimation #233

Merged
merged 6 commits into from
Jan 31, 2023
Merged

Conversation

georgeyiasemis
Copy link
Contributor

Implements Espirit calibration sensitivity map estimation and methods to calculate maximum eigenvalue numerically (e.g. powermethod)

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 83.55% // Head: 83.88% // Increases project coverage by +0.32% 🎉

Coverage data is based on head (8d26336) compared to base (5bda5c5).
Patch coverage: 98.01% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   83.55%   83.88%   +0.32%     
==========================================
  Files          88       91       +3     
  Lines        6001     6136     +135     
==========================================
+ Hits         5014     5147     +133     
- Misses        987      989       +2     
Impacted Files Coverage Δ
direct/algorithms/optimization.py 92.68% <92.68%> (ø)
direct/algorithms/__init__.py 100.00% <100.00%> (ø)
direct/algorithms/mri_algorithms.py 100.00% <100.00%> (ø)
direct/data/mri_transforms.py 97.15% <100.00%> (+0.14%) ⬆️
direct/data/transforms.py 96.47% <100.00%> (+0.16%) ⬆️
direct/types.py 83.33% <100.00%> (+5.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few remarks

  • Perhaps all should derived from Algorithm?
  • Use abc for abstract classes
  • Implement .fit(), don't use __call__() for this behaviour.

direct/algorithms/optimization.py Show resolved Hide resolved
direct/algorithms/mri_algorithms.py Show resolved Hide resolved
tests/tests_data/test_algorithms.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasteuwen jonasteuwen merged commit 28d05d5 into main Jan 31, 2023
@jonasteuwen jonasteuwen deleted the espirit-transform branch January 31, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants