-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Espirit sensitivity estimation #233
Conversation
Codecov ReportBase: 83.55% // Head: 83.88% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 83.55% 83.88% +0.32%
==========================================
Files 88 91 +3
Lines 6001 6136 +135
==========================================
+ Hits 5014 5147 +133
- Misses 987 989 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few remarks
- Perhaps all should derived from
Algorithm
? - Use
abc
for abstract classes - Implement
.fit()
, don't use__call__()
for this behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Implements Espirit calibration sensitivity map estimation and methods to calculate maximum eigenvalue numerically (e.g. powermethod)