Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learning rate scheduler can be checkpointed now #218

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

georgeyiasemis
Copy link
Contributor

@georgeyiasemis georgeyiasemis commented Jul 13, 2022

HasStateDict type changed to include torch.optim.lr_scheduler._LRScheduler which was missing before, causing the checkpointer to not save/load the state_dict of LRSchedulers.

@georgeyiasemis georgeyiasemis added the bug Something isn't working label Jul 13, 2022
@georgeyiasemis georgeyiasemis linked an issue Jul 13, 2022 that may be closed by this pull request
`torch 1.12.0` causes problems. Fix at a later stage
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #218 (aab2e3e) into main (702b8f4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   81.28%   81.26%   -0.02%     
==========================================
  Files          73       73              
  Lines        5433     5433              
==========================================
- Hits         4416     4415       -1     
- Misses       1017     1018       +1     
Impacted Files Coverage Δ
direct/nn/openvino/openvino_model.py 97.18% <100.00%> (ø)
direct/types.py 100.00% <100.00%> (ø)
direct/checkpointer.py 71.42% <0.00%> (-0.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 702b8f4...aab2e3e. Read the comment docs.

@georgeyiasemis georgeyiasemis merged commit c058f4c into main Jul 13, 2022
@georgeyiasemis georgeyiasemis deleted the lr-scheduler-fix-state-dict branch July 18, 2022 12:50
georgeyiasemis added a commit that referenced this pull request Jul 31, 2022
HasStateDict type changed to include torch.optim.lr_scheduler._LRScheduler which was missing before, causing the checkpointer to not save/load the state_dict of LRSchedulers.
georgeyiasemis added a commit that referenced this pull request Jul 31, 2022
HasStateDict type changed to include torch.optim.lr_scheduler._LRScheduler which was missing before, causing the checkpointer to not save/load the state_dict of LRSchedulers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lr_scheduler has no state_dict
1 participant