Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crop kspace transforms #210

Merged
merged 9 commits into from
Jun 19, 2022
Merged

Crop kspace transforms #210

merged 9 commits into from
Jun 19, 2022

Conversation

georgeyiasemis
Copy link
Contributor

@georgeyiasemis georgeyiasemis commented Jun 5, 2022 •
edited
Loading

Changes:

  • CropKspace transform implemented: Transforms to the image domain all coil data, crops to shape, transforms back to kspace domain
  • CropAndMask transform removed (had no cropping functionality)
  • ComputeImage transfrom implemented: computes image based on kspace
  • ApplyMask transform implemented
  • build_mri_transforms reformatted to abide to the new transforms
  • Merged from main (4463268)

@github-actions github-actions bot added the python label Jun 5, 2022
@codecov
Copy link

codecov bot commented Jun 5, 2022 •
edited
Loading

Codecov Report

Merging #210 (79f7e4e) into main (bc3a38b) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   80.79%   80.88%   +0.09%     
==========================================
  Files          72       72              
  Lines        5317     5327      +10     
==========================================
+ Hits         4296     4309      +13     
+ Misses       1021     1018       -3
Impacted Files Coverage Δ
direct/cli/utils.py 60.00% <ø> (ø)
direct/data/h5_data.py 64.82% <ø> (ø)
direct/engine.py 75.21% <ø> (ø)
direct/utils/dataset.py 94.73% <ø> (ø)
direct/__init__.py 100.00% <100.00%> (ø)
direct/data/datasets.py 88.45% <100.00%> (ø)
direct/data/mri_transforms.py 99.29% <100.00%> (+0.36%) ⬆️
direct/data/transforms.py 95.54% <100.00%> (+1.18%) ⬆️
direct/nn/mri_models.py 93.60% <100.00%> (+0.03%) ⬆️
direct/nn/rim/rim_engine.py 91.52% <100.00%> (-0.28%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3a38b...79f7e4e. Read the comment docs.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 6, 2022
@georgeyiasemis georgeyiasemis force-pushed the crop-kspace-transforms-merged branch from dbe6fc2 to 2b28b4b Compare June 6, 2022 16:41
@georgeyiasemis
Rebase from main (#212)
79f7e4e 
* Fix RIM performance (#208)

* Bring `modulus_if_complex` back with some fixes
* protobuf issues

* Bump version: 1.0.2 → 1.0.3-dev0

* Bump version: 1.0.3-dev0 → 1.0.3

* Adding JOSS paper badge
jonasteuwen
jonasteuwen requested changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments. Nothing needs to change in the configs I presume? Did you try training some models to check performance against older models?

setup.cfg Show resolved Hide resolved
@georgeyiasemis georgeyiasemis merged commit 988d46a into main Jun 19, 2022
@georgeyiasemis georgeyiasemis deleted the crop-kspace-transforms-merged branch June 19, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasteuwen jonasteuwen jonasteuwen requested changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgeyiasemis @jonasteuwen