Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sampling masks #140

Merged
merged 41 commits into from
Dec 16, 2021
Merged

Add sampling masks #140

merged 41 commits into from
Dec 16, 2021

Conversation

georgeyiasemis
Copy link
Contributor

Includes

  • Adding non-Cartesian masking functions for cartesian data (simulating non-Cartesian trajectory on data acquired on a grid)
  • Scripts for reproducing experiments as presented in "Deep MRI Reconstruction with radial subsampling"

George Yiasemis and others added 26 commits June 29, 2021 18:14
Missing f in fstring
afceed4
Adding radial mask
fa4872d
Adding radial mask
76ba218
Adding radial mask
06dd56d
Adding radial mask
d7970b3
Radial subsampling update
fd874fe
@georgeyiasemis
Fix evaluate to use last volume's last slice
e904d62
@georgeyiasemis
Black fix
ecba93c
@georgeyiasemis
Merge branch 'fix-evaluate-function' into add-sampling-masks
b4f2c21
@georgeyiasemis
Change toy base.yaml
5c29170
@georgeyiasemis
direct/data/tests/
aef3d86
@georgeyiasemis
Minor naming fix
f753aed
@georgeyiasemis
Minor naming fix
543257b
@georgeyiasemis
Fix h5slicedata logger
c22d0c2
@georgeyiasemis
Radial mask fixed to return acs
8e0c50b
@georgeyiasemis
Radial mask fixed to return acs
84e2ab5
@georgeyiasemis
Fix to overwrite standard loading of config and add predict function
4dc7b5b
@georgeyiasemis
Fix subsampling seed & test it
b3b9a90
@georgeyiasemis
Removed hashed code
3666f7f
@georgeyiasemis
Added rectilinear masking for calgary campinas dataset
b1f61f0
Cleaned calgary project and added scripts for radial subsampling project
7cd0084
Removing not needed project
ce025cc
@georgeyiasemis
Fixed evaluation function
d78e285
@georgeyiasemis
Merge branch 'fix-evaluate-function' into add-sampling-masks
b7a0e4f
@georgeyiasemis
Rebase from main
846a65d
@georgeyiasemis
Merge remote-tracking branch 'origin/main' into add-sampling-mask
5220236 
# Conflicts:
#	direct/common/subsample.py
@georgeyiasemis georgeyiasemis marked this pull request as ready for review December 16, 2021 10:32
jonasteuwen
jonasteuwen requested changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

direct/common/subsample.py Outdated Show resolved Hide resolved
direct/common/subsample.py Outdated Show resolved Hide resolved
direct/common/subsample.py Outdated Show resolved Hide resolved
direct/data/tests/test_transforms.py Outdated Show resolved Hide resolved
direct/environment.py Outdated Show resolved Hide resolved
projects/calgary_campinas/predict_test.py Outdated Show resolved Hide resolved
@georgeyiasemis georgeyiasemis linked an issue Dec 16, 2021 that may be closed by this pull request
Implement radial sampling patterns & non-uniform FFT #108
Closed
@georgeyiasemis georgeyiasemis mentioned this pull request Dec 16, 2021
Closed
@jonasteuwen jonasteuwen merged commit 1a1f93d into main Dec 16, 2021
@jonasteuwen jonasteuwen deleted the add-sampling-masks branch December 16, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasteuwen jonasteuwen Awaiting requested review from jonasteuwen

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement radial sampling patterns & non-uniform FFT
2 participants
@georgeyiasemis @jonasteuwen