Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design direct train CLI interface #136

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Design direct train CLI interface #136

merged 2 commits into from
Dec 13, 2021

Conversation

jonasteuwen
Copy link
Contributor

Addresses #109. Now python tools/train_model.py is replaced by direct train. Still need to verify other CLI tools. Can you assist @georgeyiasemis what is missing?

@github-actions github-actions bot added documentation Improvements or additions to documentation python labels Dec 11, 2021
@georgeyiasemis
Copy link
Contributor

georgeyiasemis commented Dec 13, 2021 •
edited
Loading

Addresses #109. Now python tools/train_model.py is replaced by direct train. Still need to verify other CLI tools. Can you assist @georgeyiasemis what is missing?

We have predict functions such as in python3 projects/calgary_campinas/predict_val/test.py or python3 tools/parse_metrics_log.py but I am not sure if this is required as e.g. different projects may have different predict funs

@jonasteuwen jonasteuwen merged commit 6508922 into main Dec 13, 2021
@jonasteuwen jonasteuwen deleted the improve-cli branch December 13, 2021 15:27
@jonasteuwen jonasteuwen restored the improve-cli branch December 13, 2021 15:45
jonasteuwen added a commit that referenced this pull request Dec 13, 2021
@jonasteuwen
Revert "Design direct train CLI interface (#136)"
a140081 
This reverts commit 6508922.
@jonasteuwen jonasteuwen mentioned this pull request Dec 13, 2021
Merged
jonasteuwen added a commit that referenced this pull request Dec 13, 2021
@jonasteuwen
Revert "Design direct train CLI interface (#136)" (#138)
fe43f3a 
This reverts commit 6508922.
@jonasteuwen jonasteuwen deleted the improve-cli branch December 13, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgeyiasemis georgeyiasemis georgeyiasemis approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasteuwen @georgeyiasemis