Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit when dataset is empty #125

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Exit when dataset is empty #125

merged 3 commits into from
Oct 21, 2021

Conversation

georgeyiasemis
Copy link
Contributor

@georgeyiasemis georgeyiasemis commented Oct 21, 2021 •
edited
Loading

Changes:

  • H5SliceData throws a warning if dataset is empty
  • Training is terminated if the concatenated dataset is empty
  • Inference is terminated if the detaset is empty

@georgeyiasemis georgeyiasemis linked an issue Oct 21, 2021 that may be closed by this pull request
Exit if there is no training or validation volumes #104
Closed
jonasteuwen
jonasteuwen reviewed Oct 21, 2021
View reviewed changes
Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things to address.

direct/data/h5_data.py Show resolved Hide resolved
direct/data/h5_data.py Outdated Show resolved Hide resolved
direct/engine.py Outdated Show resolved Hide resolved
direct/engine.py Outdated Show resolved Hide resolved
jonasteuwen
jonasteuwen approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasteuwen jonasteuwen merged commit a628c8b into main Oct 21, 2021
@jonasteuwen jonasteuwen deleted the fix-empty-dataset-issue branch October 21, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasteuwen jonasteuwen jonasteuwen approved these changes

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exit if there is no training or validation volumes
2 participants
@georgeyiasemis @jonasteuwen