Implement recon models #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement varnet
github-actions
bot
added
documentation
|
This is addressing #116. Can you look into pylint? |
jonasteuwen
requested changes
Oct 15, 2021
Comment on lines
+792
to
+793
| assert_complex(coil_data, complex_last=True) | ||
| assert_complex(sensitivity_map, complex_last=True) |
There was a problem hiding this comment.
Is this assert_complex still needed? Can't our internal representation completely switch to complex tensors, and use .is_complex() or so (that can be done in the assert_complex of course)?
There was a problem hiding this comment.
This will require to change the whole software & models so let's keep this as a future change
Comment on lines
-281
to
-287
| # 2D data is batched and contains keys: | ||
| # "filename_slice", "slice_no" | ||
| # "sampling_mask" of shape: (batch, 1, height, width, 1) | ||
| # "sensitivity_map" of shape: (batch, coil, height, width, complex=2) | ||
| # "target" of shape: (batch, height, width) | ||
| # "masked_kspace" of shape: (batch, coil, height, width, complex=2) | ||
|
|
There was a problem hiding this comment.
It feels we should write this down somewhere. Maybe in the documentation?
There was a problem hiding this comment.
Documentation of engine?
Rebase from main
…t into implement-recon-models
jonasteuwen
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconstruction Models added:
Additional models added: