Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added c code for binary search #88

Closed
wants to merge 2 commits into from

Conversation

prince8809
Copy link
Contributor

@prince8809 prince8809 commented Sep 30, 2018

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Fixes #44

By submitting this pull request I confirm I've read and complied with the
below declarations.

  • I have read the Contribution guidelines and I am confident that my PR reflects them.
  • I have followed the commit guidelines for this project.
  • My code follows the standard code structure.
  • This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
  • This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
  • I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

@prince8809
Copy link
Contributor Author

@codacy-badger please review

@prince8809 prince8809 changed the title Added c code for binary search and updated the readme table Added c code for binary search Sep 30, 2018
@prince8809
Copy link
Contributor Author

@sangamcse is this okey?

@sangamcse
Copy link
Member

No. Kindly go through few git tutorials before committing.

@prince8809
Copy link
Contributor Author

prince8809 commented Sep 30, 2018

what is the problem with this. @sangamcse could you please elaborate?

@sangamcse
Copy link
Member

First of all, you have not gone through contribution guidelines which are resulting in bad commit messages. 2nd, you have ticked #88 (comment) without reading it properly. We are not here to just complete someone's task and breaking our repository totally.
3rd you have not asked for any issue assignment and started working directly.

@sangamcse sangamcse closed this Sep 30, 2018
@prince8809
Copy link
Contributor Author

okey I am really sorry this is my first time contributing anywhere @sangamcse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Algo] Binary Search [C]
2 participants