Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insertionsort.java : Added InsertionSort [java] #83

Closed
wants to merge 2 commits into from

Conversation

Om-Pandey
Copy link

@Om-Pandey Om-Pandey commented Sep 30, 2018

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Fixes #63

By submitting this pull request I confirm I've read and complied with the
below declarations.

  • I have read the Contribution guidelines and I am confident that my PR reflects them.
  • I have followed the commit guidelines for this project.
  • My code follows the standard code structure.
  • This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
  • This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
  • I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

@Om-Pandey
Copy link
Author

yeah .. squashed all commits
please check .. thanks

Copy link
Member

@sangamcse sangamcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have created 2 files, delete one.
Also, Update the README table.
Change the commit message.
Do all these and commit them using git commit --amend instead of git commit

@Om-Pandey
Copy link
Author

how to update the readme ?

@sangamcse
Copy link
Member

Open README in text editor.

how to update the readme ?

@sangamcse
Copy link
Member

Also, squash your commit

@sangamcse
Copy link
Member

@sangamcse rebase

@sangamcse
Copy link
Member

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

Om-Pandey and others added 2 commits October 2, 2018 09:00
InserstionSortjava

InserstionSortjava

InserstionSort
@sangamcse
Copy link
Member

Automated rebase with GitMate.io was successful! 🎉

@sangamcse
Copy link
Member

Duplicate of #75

@sangamcse sangamcse marked this as a duplicate of #75 Oct 2, 2018
@sangamcse sangamcse closed this Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Algo] Insertion Sort [Java]
2 participants