-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuickSort.java Implemented QuickSort in java. #171
Conversation
This adds QuickSort Algorithm which return the concatenation of the quicksorted list of elements that are less than or equal to the pivot, the pivot, and the quicksorted list of elements that are greater than the pivot. Closes NITSkmOS#150
Changed tabs to spaces as asked.
Moved to appropriate folder as in the CONTRIBUTING.md guidelines.
quicksort/Java/QuickSort.java
Outdated
@@ -0,0 +1,46 @@ | |||
package lecture9; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the name of the package where I created this file locally, I will remove it. Sorry.
Comment on d3dbfeb, file queue/cpp/Queue.h, line 0. No #ifndef header guard found, suggested CPP variable is: QUEUE_CPP_QUEUE_H_ [build/header_guard] [5] Origin: CPPLintBear, Section: |
Comment on d3dbfeb, file queue/cpp/Queue.h, line 8. private: should be indented +1 space inside class Queue [whitespace/indent] [3] Origin: CPPLintBear, Section: |
Comment on d3dbfeb, file queue/cpp/Queue.h, line 10. public: should be indented +1 space inside class Queue [whitespace/indent] [3] Origin: CPPLintBear, Section: |
Fix the commented issues |
I haven't used the class Queue anywhere, I do not understand what the issue is, it would be helpful if you gave me some more details. |
This adds QuickSort Algorithm which return the concatenation of the
quicksorted list of elements that are less than or equal to the pivot, the
pivot, and the quicksorted list of elements that are greater than the pivot.
Closes #150
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Fixes #150
By submitting this pull request I confirm I've read and complied with the
below declarations.
{Tag}: Add {Algorithm/DS name} [{Language}]
, notUpdate README.md
orAdded new code
.After you submit your pull request, DO NOT click the 'Update Branch' button.