Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickSort.java Implemented QuickSort in java. #171

Closed
wants to merge 4 commits into from

Conversation

udayvig
Copy link

@udayvig udayvig commented Oct 2, 2018

This adds QuickSort Algorithm which return the concatenation of the
quicksorted list of elements that are less than or equal to the pivot, the
pivot, and the quicksorted list of elements that are greater than the pivot.

Closes #150

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Fixes #150

By submitting this pull request I confirm I've read and complied with the
below declarations.

  • I have read the Contribution guidelines and I am confident that my PR reflects them.
  • I have followed the commit guidelines for this project.
  • My code follows the standard code structure.
  • This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
  • This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
  • I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

This adds QuickSort Algorithm which return the concatenation of the
quicksorted list of elements that are less than or equal to the pivot, the
pivot, and the quicksorted list of elements that are greater than the pivot.

Closes NITSkmOS#150
Changed tabs to spaces as asked.
Moved to appropriate folder as in the CONTRIBUTING.md guidelines.
@@ -0,0 +1,46 @@
package lecture9;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the name of the package where I created this file locally, I will remove it. Sorry.

@sangamcse sangamcse added process/wip Work in Progress and removed process/pending_review labels Oct 3, 2018
@sangamcse
Copy link
Member

Comment on d3dbfeb, file queue/cpp/Queue.h, line 0.

No #ifndef header guard found, suggested CPP variable is: QUEUE_CPP_QUEUE_H_ [build/header_guard] [5]

Origin: CPPLintBear, Section: all.cpp.

@sangamcse
Copy link
Member

Comment on d3dbfeb, file queue/cpp/Queue.h, line 8.

private: should be indented +1 space inside class Queue [whitespace/indent] [3]

Origin: CPPLintBear, Section: all.cpp.

@sangamcse
Copy link
Member

Comment on d3dbfeb, file queue/cpp/Queue.h, line 10.

public: should be indented +1 space inside class Queue [whitespace/indent] [3]

Origin: CPPLintBear, Section: all.cpp.

@sangamcse
Copy link
Member

sangamcse commented Oct 4, 2018

Fix the commented issues

@udayvig
Copy link
Author

udayvig commented Oct 4, 2018

I haven't used the class Queue anywhere, I do not understand what the issue is, it would be helpful if you gave me some more details.

@sangamcse sangamcse added invalid This doesn't seem right status/stale and removed difficulty/low enhancement New feature or request hacktoberfest HACKTOBERFEST 2020 process/wip Work in Progress type/algo status/stale labels Oct 29, 2018
@sangamcse sangamcse closed this Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Algo] Quick Sort [Java]
2 participants