Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bubble Sort in C #144

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Add Bubble Sort in C #144

merged 1 commit into from
Oct 2, 2018

Conversation

123vivekr
Copy link
Member

@123vivekr 123vivekr commented Oct 2, 2018

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Closes #19

By submitting this pull request I confirm I've read and complied with the
below declarations.

  • I have read the Contribution guidelines and I am confident that my PR reflects them.
  • I have followed the commit guidelines for this project.
  • My code follows the standard code structure.
  • This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
  • This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
  • I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

@@ -0,0 +1,47 @@
#include <stdio.h>

void bubble_sort(int [], int);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space before [ [whitespace/braces] [5]

Origin: CPPLintBear, Section: all.cpp.

#include <stdio.h>

void bubble_sort(int [], int);
void print_array(int [], int);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space before [ [whitespace/braces] [5]

Origin: CPPLintBear, Section: all.cpp.

Copy link
Member

@sangamcse sangamcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change your commit message according to the contribution guide.

Use git commit --amend instead of git commit.

for further help: http://ohshitgit.com/

}
}

/* If no two wlements are swapped by inner loop, then break */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wlements --> elements

@sangamcse
Copy link
Member

Comment on 5d3041f, file euclidean_gcd/C/euclidean_gcd.c, line 6.

Missing space before ( in while( [whitespace/parens] [5]

Origin: CPPLintBear, Section: all.cpp.

This adds Bubble Sort algorithm written in C.

Closes NITSkmOS#19
@sangamcse
Copy link
Member

ack 257c37e

@sangamcse sangamcse merged commit 43c82c4 into NITSkmOS:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Algo]: Add Bubble Sort in C
2 participants