Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bst.c : Added Binary Search Tree Implemetation [C] #115

Closed
wants to merge 1 commit into from
Closed

bst.c : Added Binary Search Tree Implemetation [C] #115

wants to merge 1 commit into from

Conversation

Om-Pandey
Copy link

@Om-Pandey Om-Pandey commented Oct 1, 2018 •
edited
Loading

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Fixes #53

By submitting this pull request I confirm I've read and complied with the
below declarations.

  • I have read the Contribution guidelines and I am confident that my PR reflects them.
  • I have followed the commit guidelines for this project.
  • My code follows the standard code structure.
  • This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
  • This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
  • I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

@Om-Pandey
Copy link
Author

Om-Pandey commented Oct 1, 2018 •
edited
Loading

Commits Squashed tests passed

sangamcse
sangamcse requested changes Oct 1, 2018
View reviewed changes
Copy link
Member

@sangamcse sangamcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open PR as per the issue

insertion_sort/Java/insertionsort.java Outdated
@@ -0,0 +1,43 @@
package java;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this BST? Please remove it from this PR.

insertion_sort/java/insertionsort.java Outdated
@@ -0,0 +1,43 @@
package java;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this too

@Om-Pandey
Copy link
Author

yeah ... done ... sorry .. actually continued commits from last PR I made on insertion sort

@sangamcse
Copy link
Member

Update the README table also and Squash your commits into one.

For squash help, go through http://api.coala.io/en/latest/Developers/Git_Basics.html#squashing-your-commits

@Om-Pandey
Copy link
Author

Yeah ... about that .. how to update the README ?

@sangamcse
Copy link
Member

@sangamcse rebase

@sangamcse
Copy link
Member

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@sangamcse
Copy link
Member

Automated rebase with GitMate.io was successful! 🎉

@sangamcse
Copy link
Member

sangamcse commented Oct 2, 2018 •
edited
Loading

Open README in your text editor, update it according to given table.

Yeah ... about that .. how to update the README ?

Note: Use git commit --amend while committing.
Guide: http://ohshitgit.com/

@sangamcse sangamcse added process/wip Work in Progress and removed process/pending_review labels Oct 2, 2018
@Om-Pandey
Copy link
Author

Yeah .. did all the cleaning up but It has some conflicts in Readme ... please check

@sangamcse
Copy link
Member

@Om-Pandey Rebase your local repo
Get help from https://github.com/NITSkmOS/Algorithms/blob/master/GIT_BASICS.md#follow-up
And ping me on gitter https://gitter.im/NITSkmOS/algo if I forget

@sangamcse sangamcse assigned jadia and unassigned Om-Pandey and jadia Oct 16, 2018
@sangamcse
Copy link
Member

Closing due to inactivity

@sangamcse sangamcse closed this Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangamcse sangamcse sangamcse requested changes

Assignees
No one assigned
Labels
status/stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data Structure] Binary Search Tree [C]
3 participants
@Om-Pandey @sangamcse @jadia