-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
heap_sort.cpp: Adds Heap Sort Algorithm #107
Conversation
This adds Heap Sort Algorithm which sorts the elements in ascending order. Closes NITSkmOS#22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include this in README table also.
Comment is missing in the code.
Whatever changes you do, use git commit --amend
instead of git commit
for this PR.
heap_sort/C++/heap_sort.cpp
Outdated
} | ||
cout<<endl; | ||
return 1; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EOL missing
heap_sort/C++/heap_sort.cpp
Outdated
swap(input[0], input[i]); | ||
heapify(input, i, 0); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line missing
This adds Heap Sort Algorithm which sorts the elements in ascending order. Closes NITSkmOS#22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have created 3 commits. Squash them into one.
You can take help from http://api.coala.io/en/latest/Developers/Git_Basics.html#squashing-your-commits
# This is the 1st commit message: bubble_sort: Add C++ Implementation Add a simple C++ implementation of bubble sort Closes NITSkmOS#20 # This is the commit message NITSkmOS#2: heap_sort.cpp Adds Heap Sort Algorithm This adds Heap Sort Algorithm which sorts the elements in ascending order. Closes NITSkmOS#22
This adds Heap Sort Algorithm which sorts the elements in ascending order. Closes NITSkmOS#22 heap_sort.cpp Adds Heap Sort Algorithm This adds Heap Sort Algorithm which sorts the elements in ascending order. Closes NITSkmOS#22 Merge branch 'master' of https://github.com/thebrahminator/Algorithms into heap-sort-c++
You have changed from 3 commits to 6 commits. It will break my repo. |
Hey.
I'll try and reduce it. Sorry for this.
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Sangam Kumar <[email protected]>
Sent: Tuesday, October 2, 2018 12:12:34 AM
To: NITSkmOS/Algorithms
Cc: Vishwanath Seshagiri; Assign
Subject: Re: [NITSkmOS/Algorithms] heap_sort.cpp: Adds Heap Sort Algorithm (#107)
You have changed from 3 commits to 6 commits. It will break my repo.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#107 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AOzSc4aR1D0f8-aoqKXNHTp2ALPNXEamks5ugmIagaJpZM4XBiRC>.
|
This adds Heap Sort Algorithm which sorts the elements
in ascending order.
Closes #22
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Fixes #{ISSUE_NUMBER}
By submitting this pull request I confirm I've read and complied with the
below declarations.
{Tag}: Add {Algorithm/DS name} [{Language}]
, notUpdate README.md
orAdded new code
.After you submit your pull request, DO NOT click the 'Update Branch' button.