Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create aqs with siteid #317

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Create aqs with siteid #317

merged 3 commits into from
Mar 29, 2024

Conversation

eva0marques
Copy link
Collaborator

I show to Anisha how to do a pull request. We just called amadeus function to create a rds file in output/ with site_id, time, lat, lon, geometry. It's our first step to create spatio-temporal cross validation indexes.

@eva0marques eva0marques requested a review from Sanisha003 March 29, 2024 19:19
@kyle-messier
Copy link
Collaborator

@eva0marques @Sanisha003 Ok- that is fine as we are still going with /output. Soon that will be replaced by targets, but we'll handle that when the time comes. Thanks!

@Sanisha003
Copy link
Collaborator

Great job!

@Sanisha003 Sanisha003 closed this Mar 29, 2024
@Sanisha003 Sanisha003 reopened this Mar 29, 2024
Copy link
Collaborator

@Sanisha003 Sanisha003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @eva0marques !

@Sanisha003 Sanisha003 self-requested a review March 29, 2024 19:27
@eva0marques
Copy link
Collaborator Author

@kyle-messier yeah, it's hard to progress if we do not compose with the actual state of the library...

@eva0marques eva0marques merged commit 8e56619 into main Mar 29, 2024
4 checks passed
@kyle-messier kyle-messier deleted the create_aqs_with_siteid branch June 17, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants