Fix T-class conflicts on normal planner #420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tts-fe-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Process-ing
force-pushed
the
fix/planner-conflict-severity
branch
from
1fed85f to
7aba7e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an weird (and not so surprising) behavior, where setting
VITE_APP_T_CLASS_CONFLICTS=1will result in conflicts with theoretical classes appearing in red in the normal planner. This still need to be discussed, as it complicates unnecessarily the logic for a somewhat unreasonable requirement from the course's board.To test this PR, do not forget to set
VITE_APP_T_CLASS_CONFLICTS=1in your.envfile.