Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCM-8023: update styling on login page #155

Merged
merged 23 commits into from
Feb 11, 2025
Merged

CCM-8023: update styling on login page #155

merged 23 commits into from
Feb 11, 2025

Conversation

harrim91
Copy link
Contributor

@harrim91 harrim91 commented Feb 3, 2025 •
edited
Loading

Description

  • Updates styling of sign-in page to follow NHS Design system as per requirements
    • Updates nhsuk-frontend and nhsuk-react-components to latest versions
  • Conditionally renders Cognito IdP login form based on environment variable switch
  • Styles the Cognito IdP login form a little bit - alignment, use NHS font and colours etc.
  • Signing in with CIS2 now redirects to a new page /auth/oauth2 which handles the oauth2 redirect logic as it was competing with the other redirect logic in the main page and getting complicated to handle.

See also:

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@harrim91 harrim91 requested a review from a team as a code owner February 3, 2025 17:35
mark-r-bjss
mark-r-bjss reviewed Feb 4, 2025
View reviewed changes
src/app/page.tsx Outdated Show resolved Hide resolved
Ian-Hodges
Ian-Hodges reviewed Feb 4, 2025
View reviewed changes
src/styles/app.scss Outdated Show resolved Hide resolved
Ian-Hodges
Ian-Hodges previously approved these changes Feb 4, 2025
View reviewed changes
@harrim91
CCM-8023: feedback
257f1fb 
* text from content file
* consistent use of "sign in/out"
* spacing on cognito form
@harrim91 harrim91 requested a review from a team as a code owner February 4, 2025 16:07
Ian-Hodges
Ian-Hodges previously approved these changes Feb 5, 2025
View reviewed changes
@harrim91 harrim91 requested a review from Ian-Hodges February 7, 2025 15:06
@harrim91 harrim91 requested a review from bhansell1 February 10, 2025 16:29
@harrim91 harrim91 merged commit 0b63f9f into main Feb 11, 2025
22 checks passed
@harrim91 harrim91 deleted the feature/CCM-8023-login-screen-styling branch February 11, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhansell1 bhansell1 bhansell1 approved these changes

@mark-r-bjss mark-r-bjss mark-r-bjss approved these changes

@Ian-Hodges Ian-Hodges Awaiting requested review from Ian-Hodges

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harrim91 @Ian-Hodges @bhansell1 @mark-r-bjss