Feature/ccm 8434 cis2 signout #152
Open
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-r-bjss
approved these changes
Jan 29, 2025
chris-elliott-nhsd
approved these changes
Jan 29, 2025
| logout_urls = flatten([ | ||
| var.cognito_user_pool_additional_callback_urls, | ||
| [ | ||
| "https://${var.environment}.${local.acct.dns_zone["name"]}/auth/", |
There was a problem hiding this comment.
as we've learned from other recent bug fixes, we probably don't want the trailing slashes at the end of callback_urls and logout_urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Signing out from an OAuth provider in Amplify requires logout redirect urls to be configured in the Amplify config, and in the Cognito User Pool Client.
This PR configures the web app and the user pool client to redirect to the sign-in page on OAuth signout.
This was the existing behaviour - the existing redirect logic seems to kick in before the Cognito redirect anyway. It just stops an error from being thrown in the console.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.