Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [AEA-4755] - PUT /selectedRole #384

Merged
merged 50 commits into from
Feb 3, 2025

Conversation

kris-szlapa
Copy link
Contributor

@kris-szlapa kris-szlapa commented Jan 29, 2025

Summary

🎫 AEA-4755 PUT /selectedRole
🧪 Regression Tests: NHSDigital/electronic-prescription-service-api-regression-tests#237
👤 Audrey Ricker: 555043304334
CONFIDENTIAL: PERSONAL PATIENT DATA accessed by RICKER, Audrey - General Medical Practitioner - NO_ORG_NAME (ODS: N82668)
👤 Curtis Rogers: 555043308597
CONFIDENTIAL: PERSONAL PATIENT DATA accessed by ROGERS, Curtis - Registration Authority Manager - NO_ORG_NAME (ODS: A21293)

  • Routine Change

Details of the Fix

  • If the role with access matches selectedRoleId, it is added to the currently_selected_role but not to the roles_with_access array. Move the previously selected role back into rolesWithAccess, but only if it was set.

  • The RBAC (Role-Based Access Control) User Profile Banner follows these patterns:

    • Standard user:
      CONFIDENTIAL: PERSONAL PATIENT DATA accessed by LAST NAME, First Name - RBAC Role - Site Name (ODS: ODS)
    • Locum user:
      CONFIDENTIAL: PERSONAL PATIENT DATA accessed by LAST NAME, First Name - RBAC Role - Locum pharmacy (ODS: FFFFF) - Site Name (ODS: ODS Code)
  • The confirmButtonText contains the text: "Continue to find a prescription"

Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

Copy link

wildjames
wildjames previously approved these changes Feb 3, 2025
@kris-szlapa kris-szlapa merged commit a68a216 into main Feb 3, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants