-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: [AEA-4755] - PUT /selectedRole #384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed URL: https://cpt-ui-pr-384.dev.eps.national.nhs.uk/site |
…ithub.com/NHSDigital/eps-prescription-tracker-ui into AEA-4755-trackeruserinfo-selectedrole-fix
wildjames
previously approved these changes
Feb 3, 2025
|
wildjames
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🎫 AEA-4755 PUT /selectedRole
🧪 Regression Tests: NHSDigital/electronic-prescription-service-api-regression-tests#237
👤 Audrey Ricker: 555043304334
CONFIDENTIAL: PERSONAL PATIENT DATA accessed by RICKER, Audrey - General Medical Practitioner - NO_ORG_NAME (ODS: N82668)
👤 Curtis Rogers: 555043308597
CONFIDENTIAL: PERSONAL PATIENT DATA accessed by ROGERS, Curtis - Registration Authority Manager - NO_ORG_NAME (ODS: A21293)
Details of the Fix
If the role with access matches
selectedRoleId
, it is added to thecurrently_selected_role
but not to theroles_with_access
array. Move the previously selected role back into rolesWithAccess, but only if it was set.The RBAC (Role-Based Access Control) User Profile Banner follows these patterns:
CONFIDENTIAL: PERSONAL PATIENT DATA accessed by LAST NAME, First Name - RBAC Role - Site Name (ODS: ODS)
CONFIDENTIAL: PERSONAL PATIENT DATA accessed by LAST NAME, First Name - RBAC Role - Locum pharmacy (ODS: FFFFF) - Site Name (ODS: ODS Code)
The
confirmButtonText
contains the text: "Continue to find a prescription"