-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] New: [AEA-0000] - Redirect the user if they're not logged in #278
Open
wildjames
wants to merge
74
commits into
main
Choose a base branch
from
aea-0000-auth_redirect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+122
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-tracker-ui into AEA-4651-roles-with-access
…-tracker-ui into AEA-4651-roles-with-access
## Summary - ✨ New Feature ### Details Kris and I are working on similar features - merging my changes into his branch so that we are synchronised.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should rename this file too
wildjames
changed the title
New: [AEA-0000] - Redirect the user if they're not logged in
[DNM[ New: [AEA-0000] - Redirect the user if they're not logged in
Jan 6, 2025
wildjames
changed the title
[DNM[ New: [AEA-0000] - Redirect the user if they're not logged in
[DNM] New: [AEA-0000] - Redirect the user if they're not logged in
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
If the user is not logged in, we currently just let them sit with that.
This updates the behaviour to instead trigger the login flow if the user session is not present, or becomes invalid (e.g. expires). There is some additional logic to handle mock auth. If the deployment is in one of the approved environments (currently, anything but
prod
), then the user is sent to a login page, which allows signing in with mock or PTL, and signing out. It also displays some debugging information, and the access tokens for people who want to use these elsewhere, e.g. Postman.