Fix: [AEA-4654] - fix delete stacks

.github/scripts/delete_stacks.sh

@@ -6,11 +6,7 @@
 REPO_NAME=eps-prescription-tracker-ui
 
 # this should be a regex used in jq command that parses the output from aws cloudformation list-stacks and just captures stacks we are interested in
-CAPTURE_REGEX="^cpt-ui-(sandbox-)?pr-(\\d+)$"
-
-# this should be a regex that is used to get the pull request id from the cloud formation stack name
-# this is used in a replace command to replace the stack name so what is left is just the pull request id
-PULL_REQUEST_STACK_REGEX=cpt-ui-pr-
+CAPTURE_REGEX="^cpt-ui-pr-(\\d+)-*"
 
 CNAME_QUERY=cpt-ui-pr
 
@@ -38,7 +34,7 @@ delete_cloudformation_stacks() {
   for i in "${ACTIVE_STACKS_ARRAY[@]}"
   do 
     echo "Checking if stack $i has open pull request"
-    PULL_REQUEST=${i//${PULL_REQUEST_STACK_REGEX}/}
+    PULL_REQUEST=$(echo "$i" | grep -oP '\d+')
     echo "Checking pull request id ${PULL_REQUEST}"
     URL="https://api.github.com/repos/NHSDigital/${REPO_NAME}/pulls/${PULL_REQUEST}"
     RESPONSE=$(curl --url "${URL}" --header "Authorization: Bearer ${GITHUB_TOKEN}" 2>/dev/null)

.github/workflows/delete_old_cloudformation_stacks.yml

@@ -4,7 +4,7 @@ name: 'Delete old cloudformation stacks'
 on:
   workflow_dispatch:
   schedule:
-    - cron: "0 2,14 * * *"
+    - cron: "20 * * * *"
 
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs: