-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: [AEA-4168] - 200 response for duplicate item #384
Merged
natasafrgk
merged 13 commits into
main
from
bug/aea-4168-200-response-for-duplicate-item
Jun 14, 2024
Merged
Fix: [AEA-4168] - 200 response for duplicate item #384
natasafrgk
merged 13 commits into
main
from
bug/aea-4168-200-response-for-duplicate-item
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…//github.com/NHSDigital/eps-prescription-status-update-api into bug/aea-4168-200-response-for-duplicate-item
Quality Gate passedIssues Measures |
Orkastrated
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
2 Conflicting responses are returned for the same item if a 409 error is found due to a duplicate Task.ID. The expected 409 response is returned, however a 200 is returned with for the same Task.ID noting that the data is not committed. However, we want to maintain the response of other items and only replace the ones with a duplicate Task ID.
https://nhsd-jira.digital.nhs.uk/browse/AEA-4168
Details
Add any summary information of what is in the change. Remove this line if you have nothing to add.