updates to parameter defaults

[rgknox]

Description:

This is a set of changes to the default parameter file. Most of these parameters are derived from work by @jenniferholm

This PR also installs the first iteration of a workflow that seeks to preserve the history of changes to the default parameter file. In summary:

The changes to the default parameter file are encapsulated in a "patch file", the example here is archive/api24.1.0_101722_patch_params.xml. These changes are interpreted by tools/BatchPatchParams.py.

The pre-existing default parameter file is saved in the folder parameter_files/archive along with the patch file.

Note: This workflow is intended to use ilamb as a verification of the changes.

Note: This set of chagnes is based on branch https://github.com/rgknox/fates/tree/update_batchpatch in PR #916

Collaborators:

@jenniferholm @rosiealice @ckoven @jkshuman @mpaiao @JessicaNeedham @glemieux

Expectation of Answer Changes:

Checklist:

• My change requires a change to the documentation.
• I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
• I have read the CONTRIBUTING document.
• FATES PASS/FAIL regression tests were run
• If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

[JessicaNeedham]

Thanks @rgknox.

ILAMB runs comparing the updated parameter file with the current default in spmode and fixed biogeography no comp. Spmode was run for 50 years, fixed biogeography no comp for 200. The final 20 years are used in both cases.

spmode: https://compy-dtn.pnl.gov/need138/spmode/

fixedbiogeographynocomp: https://compy-dtn.pnl.gov/need138/fixedbiogeognocomp/

Attaching figures of VEGC and canopy crown area by pft. A jupyter notebook plotting some additional PFT-level variables is here:

https://github.com/adrifoster/fates-global-cal/blob/main/jupyter_ppe_scripts/Fixed_biogeog_no_comp.ipynb

[jenniferholm]

Hi Ryan, I think we just need to change PFT 2,3,4,6, to have recruit_seed_dbh_repro_threshold of 80, and this this PR should be good to go.

[rosiealice]

I feel like this PR has a lot of infrastructure changes to facilitate the workflow itself. It would be cool to do a follow up more minor peturbation of parameter some time soon to act as a template for how to do this workflow more operationally (e.g. perhaps with the leaf layering scheme?)

Otherwise this is cool, and I'm excited to have a process for this :)

[rgknox]

for some reason the most recent round of updates has done some re-ordering of the parameters, which it shouldn't. Will fix

[glemieux]

Regression testing on Cheyenne is complete. I generated the nc file from the new default and modified the ctsm namelist defaults to point to it. All tests run successfully aside from the known failures. As expected all testmods result in DIFFs.

Folder location on Cheyenne: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr921

[glemieux]

@rgknox should this be an API minor tag increment since its still backwards compatible (i.e. sci.1.60.2_api.24.2.0)?

[rgknox]

@glemieux , yes, I agree, minor api tag increment