Updates to target carbon sub-routine to improve readability #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: I rewrote sub-routine TargetAllometryCheck. Instead of using if statements to set logical variables, I assigned the logical variables directly. Also, I added more information to the error message in case the sub-routine fails, which may be useful for debugging. None of the changes should have impacts on FATES results.
5 tasks
glemieux
approved these changes
Jun 2, 2022
glemieux
approved these changes
Jun 2, 2022
|
All tests are b4b against |
glemieux
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I rewrote sub-routine TargetAllometryCheck. Instead of using if statements to set logical variables, I assigned the logical variables directly. Also, I added more information to the error message in case the sub-routine fails, which may be useful for debugging. None of the changes should have impacts on FATES results.
Changes in this pull request were originally part of #800.
Collaborators:
@rgknox @glemieux
Expectation of Answer Changes:
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: