Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced variable laimemory with leafmemory #865

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

mpaiao
Copy link
Contributor

@mpaiao mpaiao commented May 4, 2022

Description:

Rationale: "laimemory" was a misnomer, as we were tracking leaf biomass. I renamed it to leafmemory to be consistent with the memory term for other tissues.

Changes associated with this pull request were originally included in #800.

Collaborators:

@rgknox @glemieux

Expectation of Answer Changes:

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

Rationale: "laimemory" was a misnomer, as we were tracking leaf biomass. I renamed it
leafmemory to be consistent with the memory term for other tissues.
@glemieux
Copy link
Contributor

glemieux commented Jun 2, 2022

All expected tests pass b4b:
/glade/u/home/glemieux/scratch/ctsm-tests/tests_pr865

@glemieux glemieux merged commit ddb7056 into NGEET:master Jun 2, 2022
@mpaiao mpaiao deleted the mpaiao-pr-leaf-memory branch December 4, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants