Frost mortality fix #816
Closed
Frost mortality fix #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frost mortality needs the previous-day temperature, but the variable holding this quantity is set initially to zero. This is interpreted as 0 Kelvin by the mortality routine, triggering the mortality rate. (cherry picked from commit 6c6f5bf)
Fixed conflicts against sci.1.52.0_api.20.0.0 (running means update)
|
Closing per #724 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a cleaned up version of PR #804 from @mpaiao. It was noted that the original PR had commits overlapping with #800 so we decided to simplify this PR. The relevant commit providing the fix has been cherry-picked into a new branch for clarity. The original PR description is copied below.
Simple bug fix for the non-zero frost mortality during the first day of the simulation. The problem is that patch variable
bc_in%t_veg24_pais set to zero at the beginning of the simulation, and this is interpreted as zero Kelvin. My solution was to simply bypass frost mortality during the first simulation day. This fix addresses issue #781 and should have minimal impact on long-term simulations.Collaborators:
@mpaiao
Expectation of Answer Changes:
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: