Fix to net assimilation tracker used for trimming #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cheyenne, intel, fates test, all PASS: |
|
thanks @rosiealice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
See issue #457, it appears that during photosynthesis, the net assimilation diagnostic was not being updated correctly at night, this fixes that.
Collaborators:
@rosiealice @ckoven @walkeranthonyp
Expectation of Answer Changes:
Yes this should change answers, however long-term simulations at BCI showed a much lower sensitivity to this fix that was expected.
Checklist:
Test Results:
all PASS:
/gpfs/fs1/scratch/rgknox/clmed-tests/fates.cheyenne.intel.lmr-fix-C5dc7f0a-Fb8df885
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: