Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to modify_fates_paramfile python script #329

Merged
merged 3 commits into from
Feb 13, 2018

Conversation

ckoven
Copy link
Contributor

@ckoven ckoven commented Feb 1, 2018

Some updates / fixes to modify_fates_paramfile.py script

Description:

A couple fixes/ improvements to modify_fates_paramfile.py.
(1) uses a temporary file so that if something goes wrong during the process the outcome is that no changes are made to any of the files that were initially present.
(2) fixed the logic for scalar parameters; FATES expectation is that they aren't actually scalars but arrays of length 1 and now the tool expects that as well.

Collaborators:

n/a

Expectation of Answer Changes:

None, python tool changes only.

Checklist:

  • My change requires a change to the documentation.
  • [X ] I have updated the in-code documentation AND wiki accordingly.
  • [ X] I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

N/A: changes only to python tool so no testing needed

@rgknox
Copy link
Contributor

rgknox commented Feb 12, 2018

@ckoven , I can confirm that this PR is safe to the rest of the model. Would you like me to verify the usage of that script, or should we just pull?

@rgknox rgknox self-assigned this Feb 12, 2018
@rgknox
Copy link
Contributor

rgknox commented Feb 13, 2018

was given the thumbs up

@rgknox rgknox merged commit a3b2f4a into NGEET:master Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants