fix to logic in restarting when using a prior case's restart

[ckoven]

fix to properly restart when using finidat from a prior case

Fixes: [NGT-ED Github issue #165 ]

User interface changes?: [No]

Code review: [just me so far, @rgknox -- could you double check that this makes sense to you too?]

Test suite: ED test suite on lawrencium-lr3
Test baseline: don't have any recent baselines, so didn't run; I can't imagine this would be an issue but please double-check when testing on Yellowstone
Test namelist changes: none
Test answer changes: ought to be b4b

Test summary: all smoke, restart, etc tests pass

[rgknox]

This change will indeed prevent the cold-start initialization sequence from happening if finitdat is not specified.
My questions (which I can look into as well): 1) is the reading of restart data happening when finidata is specified (these changes may only turn off coldstart)
2) I'm wary that there are going to be confusions between finidat = ' ' and finidat = ' '. Maybe we should add a function in there that strips white space off the finidat and compares it to a null string or something.

[bandre-ucar]

I believe the finidat = ' ' with a space is intentional, at least as far as clm is concerned, but I don't remember the reason. This should be run by the clm-cmt.

[rgknox]

After reviewing the code...
Following up on question 1: the reading of the fates restart data should be happening when finitdat is specified, and from reading the code I have no suspicions that it is not. See clm_initializeMod.F90:

is_cold_start = .false.

    if (nsrest == nsrStartup) then

       if (finidat == ' ') then
          if (finidat_interp_source == ' ') then
             is_cold_start = .true.
             if (masterproc) then
                write(iulog,*)'Using cold start initial conditions '
             end if
          else 
             if (masterproc) then
                write(iulog,*)'Interpolating initial conditions from ',trim(finidat_interp_source),&
                     ' and creating new initial conditions ', trim(finidat_interp_dest)
             end if
          end if
       else 
          if (masterproc) then
             write(iulog,*)'Reading initial conditions from ',trim(finidat)
          end if
          call getfil( finidat, fnamer, 0 )
          call restFile_read(bounds_proc, fnamer, glc_behavior)
       end if

    else if ((nsrest == nsrContinue) .or. (nsrest == nsrBranch)) then

       if (masterproc) then
          write(iulog,*)'Reading restart file ',trim(fnamer)
       end if
       call restFile_read(bounds_proc, fnamer, glc_behavior)

    end if

restFile_read would be called in such a case, which will ultimately lead to the calling of clm_fates%init_restart()

Following up on question 2: the string comparison of finidat == ' ' seems to be the status quo in that part of the code, so I suppose it is fine, (and I'm just now reading Ben's commend above)

[ckoven]

closing as the change is also in #172.

[bandre-ucar]

testing

[bandre-ucar]

test status:

• clm_short - ys - pass
• ed - ys - pass (1 Lm6 test still running).
• ed - hobart - mpi/network errors, rerunning.