Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated description for stress/drought deciduous flag #1138

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

mpaiao
Copy link
Contributor

@mpaiao mpaiao commented Dec 19, 2023

Description:

This fixes the description of parameter fates_phen_stress_decid so it explains how to switch between a "hard" drought deciduous and a semi-deciduous phenology.

Collaborators:

@pollybuotte

Expectation of Answer Changes:

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@rgknox rgknox self-requested a review January 15, 2024 20:26
Copy link
Contributor

@rgknox rgknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward, no issues

@rgknox
Copy link
Contributor

rgknox commented Jan 19, 2024

No changes to code or values, so no need to run full regression suite. I did run one test where I generated a new binary parameter file from this and used it in a generic run and the model processed the file just fine. merging

@rgknox rgknox merged commit d446945 into NGEET:main Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants