Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default allometry parameters for tree PFTs #1093

Merged
merged 8 commits into from
Mar 18, 2024

update parameters with latest changes

f3fafd3
Select commit
Loading
Failed to load commit list.
Merged

Update default allometry parameters for tree PFTs #1093

update parameters with latest changes
f3fafd3
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Mar 18, 2024 in 0s

4 / 4 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Tallo includes BAAD and has a lot of additional data. But BAAD has a deciduous v evergreen label which we need. I therefore cross reference by species name so we can use the extra Tallo data with the BAAD PFT designations. Incomplete
I’m using the Martinez-Cano et al. 2019 height allometry, a power function for crown area, and the Chave et al. 2014 aboveground biomass allometry for all tree PFTs. Incomplete
We could use the Chave et al. 2014 height allometry but it depends on the environmental factor E which would need to either be read in for each grid cell or calculated from forcing data. Incomplete
The Chave et al. 2014 paper is based on more data than is in BAAD and it therefore makes sense to use parameters from that paper for tropical PFTs AGB allometries. Incomplete
For wood density I found the mean value per PFT using @mpaiao's analysis of TRY plus other data sources. Incomplete
Crown area fits are surprisingly linear even when data is binned by dbh to address issues of heteroskedasticity. Incomplete
Some PFTs contain data from many species with quite different allometries. Ideally we would do some kind of weighting based on real abundances/spatial distributions of species, rather than have the fits be based on biased sampling. For now, I have not tried to correct this. If someone wants to do a more in depth analysis that would be great! Incomplete
I’ve set the fates_allom_dbh_maxheight parameter to a large number since the Martinez-Cano function is a Michaelis-Menten and asymptotes and this parameter is therefore redundant (and potentially dangerous!). Incomplete
I have not looked at shrubs or grasses. I believe updates for those PFTs are coming from other team members. Incomplete
The in-code documentation has been updated with descriptive comments Completed
The documentation has been assessed to determine if updates are necessary Completed
FATES PASS/FAIL regression tests were run Completed
Evaluation of test results for answer changes was performed and results provided Completed
Technical Note update: Incomplete
User's Guide update: Incomplete