Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with large size initialisation in nocomp mode #1072

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Fix error with large size initialisation in nocomp mode #1072

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb25064
fix error with large size initialisation in nocomp mode
JessicaNeedham Aug 26, 2023
e402f0c
Small quality of life update to cohort age in create_cohort
rgknox Sep 11, 2023
466960b
Merge pull request #2 from rgknox/jfn-nocomplargetreeinitfix
JessicaNeedham Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions main/EDInitMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ module EDInitMod
use FatesInterfaceTypesMod , only : nlevage

use FatesAllometryMod , only : h2d_allom
use FatesAllometryMod , only : h_allom
use FatesAllometryMod , only : bagw_allom
use FatesAllometryMod , only : bbgw_allom
use FatesAllometryMod , only : bleaf
Expand Down Expand Up @@ -845,12 +846,20 @@ subroutine init_cohorts(site_in, patch_in, bc_in)
real(r8) :: stem_drop_fraction ! fraction of stem to absciss when leaves absciss
real(r8) :: fnrt_drop_fraction ! fraction of fine roots to absciss when leaves absciss
integer, parameter :: recruitstatus = 0 ! whether the newly created cohorts are recruited or initialized

real(r8),parameter :: zero_co_age = 0._r8 ! The age of a newly recruited cohort is zero
!-------------------------------------------------------------------------------------

patch_in%tallest => null()
patch_in%shortest => null()

! if any pfts are starting with large size then the whole site needs a spread of 0
do pft = 1, numpft
if (EDPftvarcon_inst%initd(pft) < 0.0_r8) then
site_in%spread = init_spread_inventory
end if
end do


! Manage interactions of fixed biogeog (site level filter) and nocomp (patch level filter)
! Need to cover all potential biogeog x nocomp combinations
! 1. biogeog = false. nocomp = false: all PFTs on (DEFAULT)
Expand Down Expand Up @@ -980,8 +989,15 @@ subroutine init_cohorts(site_in, patch_in, bc_in)
! Calculate the leaf biomass from allometry
! (calculates a maximum first, then applies canopy trim)
call bleaf(dbh, pft, crown_damage, canopy_trim, efleaf_coh, &
c_leaf)
c_leaf)

! calculate crown area of the cohort
call carea_allom(dbh, cohort_n, init_spread_inventory, pft, crown_damage, &
c_area)

! calculate height from diameter
call h_allom(dbh, pft, hite)

else
write(fates_log(),*) 'Negative fates_recruit_init_density can only be used in no comp mode'
call endrun(msg=errMsg(sourcefile, __LINE__))
Expand Down Expand Up @@ -1067,7 +1083,7 @@ subroutine init_cohorts(site_in, patch_in, bc_in)
call prt%CheckInitialConditions()

call create_cohort(site_in, patch_in, pft, cohort_n, &
hite, 0.0_r8, dbh, prt, efleaf_coh, &
hite, zero_co_age, dbh, prt, efleaf_coh, &
effnrt_coh, efstem_coh, leaf_status, recruitstatus, &
canopy_trim, c_area, 1, crown_damage, site_in%spread, bc_in)

Expand Down