-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grass PFT' #884
Comments
Thanks @ZacharyRobbins for identifying this! |
@ZacharyRobbins could you point to the location in the code where you see grasses contributing to CWD please? |
@rgknox I think the issue is here: https://github.com/NGEET/fates/blob/master/biogeochem/EDPhysiologyMod.F90#L2248-L2272. The sapwood gets routed to CWD pools when it turns over, whether it is from woody or nonwoody plants. Since grasses can still have "sapwood" (i.e. live stem biomass) in their allometry, that biomass get sent to the CWD pools. And since FATES uses the same partitioning to fuel classes for all PFTs / plant sizes, that is generating small but nonzero amounts of coarse fuel. |
Agreed. Thank you for identifying this @ZacharyRobbins and a fix for the problem! |
In response to issue NGEET#884 Modified EDCohortDynamicsMod.F90 (@ln970): if the pft is grass then all of its organs are treated as leaves for calculation of coarse woody debris(cwd). EDPatchDynamicsMod.F90 (@ln 1641): When patches spawn, only tree pft donate dead tress or cwd, and mass to the new patch, if pft is grass it assumed that grass was consumed in fire. This may not resolve fluxes to the atmosphere accurately. EDPhysiologyMod.F90 (@ln 2199): When other litter fluxes occur, if pft is grass, then it only turnsover or contributes leaves not coarse woody debris.
Closed per #891 |
Currently grass PFT's have the same assignment as all cohorts with regards to allocation of coarse woody debris (and thus fuels). This ultimately results in grass producing 1000 hour fuels, 100 hour fuels and other nonsense. Ultimately the best fix for this would be to make CWD assignment a PFT parameter so each PFT can assign to different pools based on the fuel it would produce. However in the short term my fix has been to say if PFT is not woody then all the normal CWD pools go to the dead leaves pool. This works in the case of grass, however, would not work with grass, chaparral and a tree PFT. Below I illustrate the fuel output for a grass PFT, as you can see it creates trunk fuels (based on fuel classification) which don't map well with how spitfire works.
@ckoven
The text was updated successfully, but these errors were encountered: