Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plant hydraulics failure calculating rhizosphere shells #504

Closed
pollybuotte opened this issue Mar 15, 2019 · 7 comments
Closed

Plant hydraulics failure calculating rhizosphere shells #504

pollybuotte opened this issue Mar 15, 2019 · 7 comments

Comments

@pollybuotte
Copy link

I have a single point case with one active PFT, created with this script
create_fates_single_pt.txt
This case ran for 100 years with plant hydraulics off. With hydraulics on it fails with this error in the cesm.log:

image

From line 5182 in PlantHydraulicsMod it appears the problem may be zero area in the rhizosphere shells:
image

Can anyone suggest reasonable values for the absorbing root radius (currently 0.0001) or specific root length (currently 25) that may cure the problem? Or if the source of the error is elsewhere? Thanks.

@xuchongang
Copy link
Contributor

@pollybuotte, would you please let me know which year does this happen? I think this should not be related to radium and specific root length.

@pollybuotte
Copy link
Author

@xuchongang, this happens the first year of the simulation. In this case that was 1979.

@JunyanDing
Copy link
Contributor

I got this error message too. I think the cause of this is there is no plants left at that time. The area in the code is the area of forest cover. In my case, this error either occur in the first year or about 20 yr after.

@ckoven
Copy link
Contributor

ckoven commented Apr 1, 2019

@JunyanDing the area being passed here: https://github.com/NGEET/fates/blob/master/biogeophys/FatesPlantHydraulicsMod.F90#L1643
isn't the canopy area, its the nominal FATES site area (which is a constant = 1 ha), so this shouldn't be the issue here. Perhaps the root length is becoming a tiny negative number and thus its getting a complex answer in https://github.com/NGEET/fates/blob/master/biogeophys/FatesPlantHydraulicsMod.F90#L5182?

In any case, sounds like a thing that needs to be done is to go through and add some conditionals, setting root uptake and or perhaps a high level conditional to set overall plant hydraulic dynamics as zero when the plant coverage gets to be very small?

@pollybuotte
Copy link
Author

@JunyanDing I ran a case with prescribed, static stand structure. It successfully made it through the first year, past the July 13 failure date. I'm now running for 50 years. Maybe this will help us track down the problem.

@pollybuotte
Copy link
Author

These figures show water content across root shells. It appears the lack of ordering from inner to outer by water content and instances of 0 water are problems.
image

@bchristo suggested looking into FillDrainRhizShells. A brief look indicates there may be a problem when dwat_kg=0 and shells do not get ordered according to water content starting on line 2098.

@rgknox
Copy link
Contributor

rgknox commented Jul 28, 2022

this seems pretty old and we have changed the hydro code significantly since this post, @pollybuotte feel free to re-open if this issue is still relevant

@rgknox rgknox closed this as completed Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants