Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make a history dimension for hydraulic soil radial dimension #497

Open
ckoven opened this issue Mar 5, 2019 · 2 comments
Open

make a history dimension for hydraulic soil radial dimension #497

ckoven opened this issue Mar 5, 2019 · 2 comments

Comments

@ckoven
Copy link
Contributor

ckoven commented Mar 5, 2019

Given that the soil model includes a radial dimension around roots in each soil layer which it represents as multiple soil shell layers, it would be good to allow the model to properly output that. Right now this is handled via a bit of a work-around hack, e.g. in these places:

https://github.com/NGEET/fates/blob/master/main/FatesHistoryInterfaceMod.F90#L387
https://github.com/NGEET/fates/blob/master/main/FatesHistoryInterfaceMod.F90#L2906
https://github.com/NGEET/fates/blob/master/main/FatesHistoryInterfaceMod.F90#L3166

This is fragile since the size x age class dimension could be smaller than the nlevsoi x nshell, which would likely give buffer overflows. So I think we should pull this dimension out and make it a thing.

@ckoven
Copy link
Contributor Author

ckoven commented Mar 6, 2019

also related, the soil water uptake diagnostic is using separate variables for each layer instead of using an nlevsoi-dimensioned variable. would be good to consolidate and dimension properly, both the history variable and the cohort-level variables tracking these diagnostic quantities. e.g. these places:
https://github.com/NGEET/fates/blob/master/biogeophys/FatesPlantHydraulicsMod.F90#L2844
https://github.com/NGEET/fates/blob/master/main/FatesHistoryInterfaceMod.F90#L3065
https://github.com/NGEET/fates/blob/master/main/FatesHydraulicsMemMod.F90#L269
Sorry to be nitpicky, but this all threw me off while trying to read it and work backwards from the history outputting...

@rgknox
Copy link
Contributor

rgknox commented Aug 14, 2020

This diagnostic should help us make sure that #504 is no longer an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ❕Todo
Development

No branches or pull requests

2 participants