You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Given that the soil model includes a radial dimension around roots in each soil layer which it represents as multiple soil shell layers, it would be good to allow the model to properly output that. Right now this is handled via a bit of a work-around hack, e.g. in these places:
This is fragile since the size x age class dimension could be smaller than the nlevsoi x nshell, which would likely give buffer overflows. So I think we should pull this dimension out and make it a thing.
The text was updated successfully, but these errors were encountered:
Given that the soil model includes a radial dimension around roots in each soil layer which it represents as multiple soil shell layers, it would be good to allow the model to properly output that. Right now this is handled via a bit of a work-around hack, e.g. in these places:
https://github.com/NGEET/fates/blob/master/main/FatesHistoryInterfaceMod.F90#L387
https://github.com/NGEET/fates/blob/master/main/FatesHistoryInterfaceMod.F90#L2906
https://github.com/NGEET/fates/blob/master/main/FatesHistoryInterfaceMod.F90#L3166
This is fragile since the size x age class dimension could be smaller than the nlevsoi x nshell, which would likely give buffer overflows. So I think we should pull this dimension out and make it a thing.
The text was updated successfully, but these errors were encountered: