Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things to add/fix for next interface update #263

Closed
rgknox opened this issue Aug 17, 2017 · 12 comments
Closed

Things to add/fix for next interface update #263

rgknox opened this issue Aug 17, 2017 · 12 comments

Comments

@rgknox
Copy link
Contributor

rgknox commented Aug 17, 2017

In the spirit of keeping a minimal number of backwards incompatible updates to the interface. Lets keep a list of things/features/fixes that should be included in the next update.

@rgknox
Copy link
Contributor Author

rgknox commented Aug 17, 2017

Item: Both host models ACME and clm-fates read in the namelist variable use_fates_logging, but I forgot add that to the list of variables passed into fates. For the time being, we can turn logging on and off via the "logging event flag" in the parameter file.

@rgknox
Copy link
Contributor Author

rgknox commented Aug 23, 2017

Item: Add new pft dimension'ed parameter carbon to biomass ratio, or carbon fraction, C2B... something that reflects that ratio. In ED2 we used a "C2B" multiplier, which usually was around 2.0. @bchristo mentioned that this parameter deviates from 2.0 and has implications for the hydraulics code.
@rosiealice and @ckoven, does a C2B parameter have any bearing on the litter fluxes and how they are broken down?

@bchristo
Copy link

bchristo commented Aug 23, 2017 via email

@rgknox
Copy link
Contributor Author

rgknox commented Sep 22, 2017

item: any new parameters derived from #276

@rgknox
Copy link
Contributor Author

rgknox commented Oct 5, 2017

from #283, remove slascaler as a parameter and from the file, adjust default slope parameter for diameter to leaf biomass allometry to accomodate the difference and maintain similar results

@ckoven
Copy link
Contributor

ckoven commented Oct 5, 2017

now that fates has its own dedicated parameter file, and thus every parameter in that file is fates-specific, would it be heretical to suggest deleting the 'fates_' prefix in each parameter?

@rgknox
Copy link
Contributor Author

rgknox commented Oct 5, 2017

I see no reason to keep the "fates_" namespace". It might be a hassle to those with tailor made parameter files to change all the names around, but emacs could make the fix in seconds knowing the right commands.

@rosiealice
Copy link
Contributor

rosiealice commented Oct 5, 2017 via email

@huangmy
Copy link

huangmy commented Oct 5, 2017

I agree with @rosiealice. On the other hand, the fates parameter names tend to be longer than the HLM parameter names. Would it be helpful to add more information into attributes while shorten the names a little bit?

@rosiealice
Copy link
Contributor

rosiealice commented Oct 5, 2017 via email

@ckoven
Copy link
Contributor

ckoven commented Oct 5, 2017

ok, lets keep the fates_ prefixes

@ckoven
Copy link
Contributor

ckoven commented Oct 10, 2017

ok these changes are all in master now. closing.

@ckoven ckoven closed this as completed Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants