Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed update to commit template #11

Closed
bandre-ucar opened this issue Feb 5, 2016 · 2 comments
Closed

Proposed update to commit template #11

bandre-ucar opened this issue Feb 5, 2016 · 2 comments

Comments

@bandre-ucar
Copy link
Contributor

After using the current commit template for a while, I'd like to propose a couple of minor tweaks.

  • Move the fixes, user interface, and code review above the testing so it is more visible.
  • include machine name and compiler as part of test suite info
  • test status --> test answer changes: bit for bit, roundoff, climate changing,
  • test summary:
    • summary of expected results (pass except for expected failures documented in the expected fails files.
    • details of unexpected results (new expected fails)

New template:

[ 50 character, one line summary ]

[ Description of the changes in this commit. It should be enough
  information for someone not following this development to understand. 
  Lines should be wrapped at about 72 characters. ]

Fixes: [NGT-ED Github issue #]

User interface changes?: [Yes (describe what changes), No]

Code review: [Names]

Test suite: [suite name, machine, compilers]
Test baseline:
Test namelist changes:
Test answer changes: [bit for bit, roundoff, climate changing]
Test summary:
@rgknox
Copy link
Contributor

rgknox commented Feb 5, 2016

Looks fine to me.

@bandre-ucar
Copy link
Contributor Author

I've updated the wiki.

@jkshuman jkshuman mentioned this issue Sep 11, 2017
glemieux pushed a commit that referenced this issue Feb 4, 2020
Add stem drop fraction check for flushing
glemieux pushed a commit that referenced this issue Oct 31, 2022
Update BatchPatchParams stack to modify the history attribute
glemieux pushed a commit that referenced this issue Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants