Issue 45 #47
Merged
Issue 45 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable setting permissions on certificate directory * Enable defining certificate path on clients * Enable defining key usage, default non because of redis * Update docs
widhalmt
requested changes
Oct 27, 2022
There was a problem hiding this comment.
More or less my request can be summed up as "please prefix all variables with the name of the role". If there's a good reason you don't want that here, that might be ok for. e.g. when you need variables for interaction between roles.
if you want to accept my suggestion, you can make your life easier by just running sed -i 's/client_ca/ca_client_ca/g' filename on every file you changed and pushing that. I'll happily review it again.
|
@widhalmt Thanks for the hint and the help. Your suggested changes have been done. |
widhalmt
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #45
These are some changes which suit the redis usage of this role.