Prepare release 1.1.1 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
scanon
commented
Dec 6, 2024
scanon
commented
- Update changelog
- Update version
- Switch to getting version from code
- Add version to infohpc
- Update changelog - Update version - Switch to getting version from code - Add version to infohpc
|
I greatly appreciate that most of the changes allow for future updates to be made more easily. One minor change that should be addressed: in your update of CHANGELOG.md - convience should be convenience. |
|
I should note that I have not tested, but would be willing to do so if you need a full review. All of the updates are relatively minor, and I'm not sure what is required. |
This fixes the /etc location so there aren't files in /usr/etc. This also allows getting the version for the rpm from the version file.
I think we can lose this line ensuring the /etc dir is created, and if we retain it it should move before the first install line
Fix up RPM locations
danfulton
approved these changes
Dec 10, 2024
| @@ -2,9 +2,14 @@ | |||
|
|
|||
| # build python packages | |||
| DIST=dist | |||
| pip3 install . | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.