Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial delay and scale wait parameters with ntasks #118

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Add initial delay and scale wait parameters with ntasks #118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e85db80
Add initial delay for shared run to help avoid startup stampede
dmargala Oct 21, 2024
d445a26
scale wait timeout and poll interval with ntasks
dmargala Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions podman_hpc/podman_hpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import sys
import os
import math
import socket
import re
import time
Expand All @@ -14,6 +15,14 @@
from subprocess import Popen, PIPE


def _round_nearest(x, a):
return round(x / a) * a


def _param_scale_log2(x, p):
return _round_nearest(p*(1 + math.log2(x)), p)


def podman_devnull(cmd, conf):
"""
Run a command and ignore the output.
Expand Down Expand Up @@ -310,9 +319,13 @@ def _shared_run(conf, run_args, **site_opts):
# wait for container to exist
comm = ["container", "exists", container_name]
start_time = time.time()
while podman_devnull(comm, conf) != 0:
time.sleep(conf.wait_poll_interval)
if time.time() - start_time > conf.wait_timeout:
wait_poll_interval = _param_scale_log2(ntasks, conf.wait_poll_interval)
wait_timeout = _param_scale_log2(ntasks, conf.wait_timeout)
while True:
time.sleep(wait_poll_interval)
if podman_devnull(comm, conf) == 0:
break
if time.time() - start_time > wait_timeout:
msg = "Timeout waiting for shared-run start"
raise OSError(msg)
if run_thread and run_thread.exitcode:
Expand Down