Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new design for learningpath save page when shared #2403

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

amatho
Copy link
Contributor

@amatho amatho commented Mar 6, 2025

Fixes NDLANO/Issues#4306

@amatho
Copy link
Contributor Author

amatho commented Mar 6, 2025

Blir kanskje litt rart når modalen viser det samme som i bakgrunnen?

bilde

@amatho amatho requested review from a team March 6, 2025 08:13
@gunnarvelle
Copy link
Member

Du treng kanskje ikkje vise dialogen her når skjemaet viser det samme? Dialog må vises om du deler fra lista sjølvsagt, men får du til å ikkje vise den her?

@amatho
Copy link
Contributor Author

amatho commented Mar 6, 2025

Du treng kanskje ikkje vise dialogen her når skjemaet viser det samme? Dialog må vises om du deler fra lista sjølvsagt, men får du til å ikkje vise den her?

Spurte Hedvig og hun sa den skulle vises første gang man deler, men hvis man kommer tilbake så skal det vise at man har delt

@amatho amatho merged commit fa527c5 into master Mar 6, 2025
6 checks passed
@amatho amatho deleted the new-design-save-and-share branch March 6, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants