Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: do not differentiate components based on detected device. #2401

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

Jonas-C
Copy link
Contributor

@Jonas-C Jonas-C commented Mar 5, 2025

Instead, hide and show elements based on the screen size.

Fjerner react-device-detect, da vi egentlig ikke bruker det noe særlig. Det ble brukt to steder, der to av stedene dekket en bug i ark som jeg tror har blitt fikset. Det siste stedet var noe conditional rendering i Min NDLA, som helt fint kan håndteres med litt lur kode. Vi må teste denne på en ordentlig mobil når den går inn.

Instead, hide and show elements based on the screen size.
@Jonas-C Jonas-C requested a review from a team March 5, 2025 15:11
Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jonas-C Jonas-C merged commit cc4acb6 into master Mar 7, 2025
6 checks passed
@Jonas-C Jonas-C deleted the refactor/no-device-detect branch March 7, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants