Return focus on delete and save steps #2370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Burde vi også sette fokus til "rediger steg"-knappen når man redigerer et steg og trykker lagre? |
|
Og sette fokus til "Legg til nytt steg" når man trykker på "Legg til nytt steg" -> "Avbryt"? |
…gpath-step-return-focus-on-delete-and-save
MaPoKen
commented
Feb 21, 2025
|
|
||
| const onOpenCreate = async () => { | ||
| setIsCreating(true); | ||
| setTimeout(() => document.getElementById("create-step-form")?.getElementsByTagName("input")?.[0]?.focus(), 500); |
There was a problem hiding this comment.
Dette var eneste løsningen jeg kom på for å håndtere lazy loadingen av komponenten? Er det kanskje mulig å lazyloade kun richTextEditor? Eller var det dumt å gjøre?
There was a problem hiding this comment.
Nei, det holder dessverre ikke å kun lazyloade RichTextEditor. Serialisering og deserialisering skjer utenfor RichTextEditor, og drar inn alt av slate-pakker.
MaPoKen
force-pushed
the
learningpath-step-return-focus-on-delete-and-save
branch
from
bb765cc to
c41822d
Compare
…gpath-step-return-focus-on-delete-and-save
Jonas-C
reviewed
Feb 27, 2025
| @@ -93,3 +93,5 @@ export const formValuesToGQLInput = (values: FormValues) => { | |||
| }; | |||
|
|
|||
| export const learningpathListItemId = (id: number) => `learningpath-${id}`; | |||
|
|
|||
| export const learningpathStepListItemId = (id: number) => `learningpathstep-${id}`; | |||
There was a problem hiding this comment.
Disse er litt vanskelig å skille mellom synes jeg. Kunne vi renamet de?
|
|
||
| const onOpenCreate = async () => { | ||
| setIsCreating(true); | ||
| setTimeout(() => document.getElementById("create-step-form")?.querySelector("input")?.focus(), 500); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setter nå fokuset til å gå til rediger knappene når du sletter/lager nytt steg.
Om du sletter og det ikke er noen andre steg i listen så settes den til
SKIP_TO_CONTENT, velger å ikke sette den tilLegg til stegknappen da den knappen ikke nødvendigvis er der.