Amend Drag Text dropzone aria label #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otacke
force-pushed
the
override-dropzone-label
branch
from
a266f7e to
a5c7675
Compare
|
Current version: v1.0.27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged in, will amend the aria labels of Drag the Words' drop zones, so one knows what translation should be dropped.
Please note that I deliberately did not bump the patch version. Before rolling this out, the parameters that get passed via H5P core should be sanitized. In particular, the default values for translatable fields should be set. Otherwise, two things will happen:
When installing this update, the newly added field will never have been set in existing content, thus be undefined, and the ARIA label would be amended with something like "[Missing translation for ...]".
When using Vocabulary Drill as subcontent in compound content types which create content instances (for preview), e.g. Course Presentation, Vocabulary Drill will crash, because it will not be passed any parameters at all.