feat: display question content as grid #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boyum
approved these changes
Oct 13, 2023
|
Current version: v1.0.22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lines up the source and target words in separate columns in a grid. The word utils
createFillInStringandcreateDragTextStringhave been changed to ensure that this is possible. In H5P.Blanks the source words are now placed inside their ownspanso it is easier to add css to it.Adds a line between each row in the grid to make it easier for users to connect the source and targets words (if there is a lot of space between them). Could potentially use a color with more contrast to the background color to enhance it even more if needed.
Makes the input fields in H5P.Blanks the same width. Note that this is a fixed width and that the
inputwill not change width based on the input text as before. The fixed width should be tested to see if it is suitable.Adds
overflow-x: autoto the content to ensure that it is visible and reachable on mobile if there are some really long words. This is mostly a concern when checking answers and the grid takes up more of the width. Since the content is now displayed in a grid it will not be as responsive on its own anymore. We could also look at wrapping the content instead of enabling scroll, but it will require more time. Mobile accessibility should be tested more to ensure the best accessibility on this content type.