Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IR3 Code #294

Closed
F-said opened this issue Aug 27, 2021 · 2 comments
Closed

Fix IR3 Code #294

F-said opened this issue Aug 27, 2021 · 2 comments
Labels
bug something isn't working

Comments

@F-said
Copy link
Contributor

F-said commented Aug 27, 2021

Describe the bug
Test case fails as described below.

Expected behavior
Test case should run correctly

Screenshots
image
@F-said F-said added the bug something isn't working label Aug 27, 2021
@F-said F-said changed the title IR3 Fails Fix IR3 Code Aug 27, 2021
@F-said F-said mentioned this issue Aug 31, 2021
Closed
@F-said
Copy link
Contributor Author

F-said commented Aug 31, 2021

Consider what errors could occur while using the ica function:

  • user tries to use silly data (ex: pd dataframe) w/filter TypeError
    • hard stop maybe? don't try to preprocess garbage data. Need feedback on this as well.

F-said added a commit that referenced this issue Aug 31, 2021
@F-said
Fixed #294, included proper error catching for ICA
e3fb016
@F-said F-said mentioned this issue Sep 1, 2021
Merged
@SDOsmany
Copy link
Contributor

SDOsmany commented Sep 3, 2021 •
edited
Loading

Consider what errors could occur while using the ica function:

  • user tries to use silly data (ex: pd dataframe) w/filter TypeError

    • hard stop maybe? don't try to preprocess garbage data. Need feedback on this as well.

What would be a good reason to hard stop the preprocess of silly data?

Instead of a hard stop maybe is better to just notify that the data is silly.

@F-said F-said closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@F-said @SDOsmany