Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FR3 Exception #293

Closed
F-said opened this issue Aug 27, 2021 · 1 comment
Closed

Fix FR3 Exception #293

F-said opened this issue Aug 27, 2021 · 1 comment
Labels
bug something isn't working

Comments

@F-said
Copy link
Contributor

F-said commented Aug 27, 2021

Describe the bug
Must raise an exception when data being filtered is invalid. Check in the negative rather than the positive ("if data is NOT raw data" vs "if data is None, if data is NaN, if data is...")

Expected behavior
Exception is raised

Screenshots
image

@F-said F-said added the bug something isn't working label Aug 27, 2021
@F-said F-said changed the title Fix FR3 Fix FR3 Exception Aug 27, 2021
@F-said
Copy link
Contributor Author

F-said commented Aug 31, 2021

Consider what errors could occur while using the filter function:

  • user tries to use Epochs into filter (is this really an error?) TypeError
    • Need feedback on. Why would this happen?
  • user tries to use silly data (ex: pd dataframe) w/filter TypeError
    • hard stop maybe? don't try to preprocess garbage data. Need feedback on this as well.
  • ValueError: Stop bands are not sufficiently separated ValueError
    • bad params, don't try to filter, but continue w/preprocess

If we assume that filter_feature only runs w/in pipeline, we can safely ignore these exceptions. However, say a savvy researcher wants to dig around this code and use the features in their own forked branch, then appropriate error handling would be nice.

@F-said F-said closed this as completed Aug 31, 2021
@F-said F-said reopened this Aug 31, 2021
@F-said F-said mentioned this issue Aug 31, 2021
F-said added a commit that referenced this issue Aug 31, 2021
@F-said F-said closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant