Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

[PRTL-2596] Binning UX/Styling Improvements #2568

Merged
merged 28 commits into from
Jun 10, 2019
Merged

[PRTL-2596] Binning UX/Styling Improvements #2568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
1afb595
Part of implement.
yuanhengzhao May 13, 2019
21065f6
Part of implement.
yuanhengzhao May 13, 2019
3649b99
Added the GroupValuesModal and bins objects.
yuanhengzhao May 14, 2019
c0bb6f0
Created function to update the group bins.
yuanhengzhao May 15, 2019
a3c1923
Added group button, and warning message.
yuanhengzhao May 16, 2019
01f496c
Changed the way to get groupName
yuanhengzhao May 16, 2019
d5c28c3
Changed the modal based on feedback.
yuanhengzhao May 22, 2019
58bc263
Removed empty line.
yuanhengzhao May 22, 2019
b54eb88
merged into develop
yuanhengzhao May 22, 2019
b68193e
Removed bins with empty key from customBins.
yuanhengzhao May 23, 2019
3267b6b
Removed console.
yuanhengzhao May 23, 2019
ade0bfd
Improved onclick function of '<<' button
yuanhengzhao May 24, 2019
28f4732
Added style to model.
yuanhengzhao May 28, 2019
8f84940
Merged.
yuanhengzhao May 30, 2019
598cb9e
Updated the groupValuesModal.
yuanhengzhao Jun 3, 2019
20f1d02
changed the warning message; added the numbers of data in hidden valu…
yuanhengzhao Jun 3, 2019
12e03fd
Added outsideClickHandlerDisabled to false in GroupValuesModal.
yuanhengzhao Jun 3, 2019
a5c69d6
Sorted the binData before displaying it.
yuanhengzhao Jun 3, 2019
726710f
Updated bins when setId and totalDocs number changes.
yuanhengzhao Jun 4, 2019
dd2d817
Added warning after each group name. Changed toggleEditingAndSave fun…
yuanhengzhao Jun 5, 2019
a697089
Created a new file to handle editable row in GroupValuesModal.
yuanhengzhao Jun 5, 2019
399f808
Removed values that equal to 0 when switch cohort.
yuanhengzhao Jun 5, 2019
0ca76c7
Restored old editablelabel since I create a new one for groupvaluesmo…
yuanhengzhao Jun 5, 2019
8d7d2bc
Improved types. Added cardFilters variable.
yuanhengzhao Jun 6, 2019
d13166a
merged into devleop.
yuanhengzhao Jun 6, 2019
13cba84
Merged develop.
yuanhengzhao Jun 6, 2019
0597b65
Fixed comments.
yuanhengzhao Jun 6, 2019
b0eb156
Merged into develop.
yuanhengzhao Jun 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ module.exports = {
'arrow-body-style': 'off',
'arrow-parens': 'off',
'camelcase': ['warn', {
allow: ["^UNSAFE_"],
allow: ["^UNSAFE_", "doc_count"],
}],
'comma-dangle': ['warn', 'always-multiline'],
'func-names': ['warn', 'as-needed'],
Expand Down Expand Up @@ -179,7 +179,7 @@ module.exports = {
'react/sort-comp': 'warn',
'react/sort-prop-types': 'error',
'react/prop-types': 'off', // Disable prop-types as TS is used for type checking.
'sort-destructure-keys/sort-destructure-keys': ['warn' , {
'sort-destructure-keys/sort-destructure-keys': ['warn', {
caseSensitive: false,
}],
'@typescript-eslint/explicit-function-return-type': 'off', // Allows functional components, should be fixed soon: https://github.com/typescript-eslint/typescript-eslint/issues/149
Expand Down
Loading